831918 - Story - Pin, Unpin, Hide, and Restore a Top Site

Status: VERIFIED FIXED

(Tracking Graveyard :: Metro Operations, defect, P2)

Description

[Asa Dotzler [:asa]]

Attachment: UC-53 Pin, unpin, hide, and restore a Top Site

Comment 1

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/621b1875145e

Comment 2

[Sam Foster [:sfoster] (he/him)]

Mistaken ticket number on my commit maybe, this shouldnt have been closed yet.

Comment 3

[Sam Foster [:sfoster] (he/him)]

All dependent bugs now in m-c, this should be good to go

Comment 4

[Virgil Dicu [:virgil] [QA]]

Mozilla/5.0 (Windows NT 6.2; WOW64; rv:23.0) Gecko/20130429 Firefox/23.0

Verified the story:
- Right click on a Top Sites tile brings up the context app bar with "Hide" and "Pin tab" options;
- Right click a group of tiles in Top Sites brings up the context app bar with "Hide", "Pin tab" and "Remove selection" options;
- Clicking "Pin button" visually reflects the tile, or group of tiles, that they are in pinned state;
- Clicking "Unpin button" removes the pinned visual style from the tile or group of tiles;
- Clicking "Hide" makes the selected tile or group of tile to disappear;
- Clicking the "Restore" button makes the hidden tile or group of tiles to re-appear;
- For multiple selections, context app bar appears is raised, "Remove selection" button appears, clicking this button removes the selection of tiles.

Comment 5

[Brian R. Bondy [:bbondy]]

I find it confusing that the same icon is used to delete tiles as is used to dismiss the appbar. The first time I clicked it I was thinkign it would dismiss my selection appbar, but it deleted my tiles.

The undo button is nice, but I think a different icon should be used anyway.

Comment 6

[Brian R. Bondy [:bbondy]]

Tested as per Comment 4 and posted a new defect here: Bug 875937
Tested with:
http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013-05-24-05-05-55-mozilla-central/firefox-24.0a1.en-US.win32.installer.exe

Comment 7

[Yuan Wang(:Yuan) – Mobile Firefox Design Lead]

(In reply to Brian R. Bondy [:bbondy] from comment #5)
> I find it confusing that the same icon is used to delete tiles as is used to
> dismiss the appbar. The first time I clicked it I was thinkign it would
> dismiss my selection appbar, but it deleted my tiles.
> 
> The undo button is nice, but I think a different icon should be used anyway.

That's a good catch, Brian.
I agree that using the same "Close" btn for "Delete" action can be confusing. On the mockup Stephen posted, the icons all have labels below, which could help users identify them.

But I think a better solution here should be using a different metaphor for "Delete top sites", like "Trash can". 

Stephen, any thoughts on the "Delete" icon?

Comment 8

[Brian R. Bondy [:bbondy]]

Trash can would work

Comment 9

[Brian R. Bondy [:bbondy]]

Did not find additional new issues for it8 testing other than what's mentioned in Comment 6 and already posted as a bug using today's Nightly build.

Comment 10

[Stephen Horlander [:shorlander]]

Yeah we have X icon overload. A trash could work. I will try it.

Comment 11

[Kamil Jozwiak [:kjozwiak]]

Went through the following "Story" for iteration #9 testing and found a defect. Used the following build:

http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013-06-26-03-11-00-mozilla-central/

- Went through the original story and the test cases that have been added in comment 4 and found a defect relating to the "Pin" icon not changing states when selected. Added Bug 887621

Comment 12

[Samvedana (:Samvedana)]

User Agent: Mozilla/5.0 (Windows NT 6.2; WOW64; rv:26.0) Gecko/20100101 Firefox/26.0
Build ID: 20130819030205
Built from http://hg.mozilla.org/mozilla-central/rev/c8c9bd74cc40

WFM
Tested on windows 8 using latest nightly for iteration-12. Followed steps provided in user story and comment4, and got expected result.